• Closed by: Marek
  • Closed on: 28.12.17, 12:13
  • Reason: Closed
  • Comment: Glad to help!

Ticket #10970 - Several problems and suggestions

Hello Marek,

As our project for this clients is coming to its final stage, I came up with several problems or suggestions.

Here they are:

1) Link on highlighted product photo in “pk_products” is covered by product action div in it’s upper part making it unclickable. Compare product action div in highlighted product and miniature in carousel to see the difference.

2) Flex menu hamburger label in mobile has strange translation - “Zakładki” in Polish - and I don’t know where to translate this label.

3) When I turn off “Disable all overwrites” in Performance >Debug section, all category pages are returning Error 500. Should this really work this way?

4) Active filter module has two major problems:

a) First - it’s a H1 header which, harms SEO of all categories. It should be exactly as other sidebar modules - H4 and every single filter should the be H5 or H6.
b) Second - it’s translation is wrong and I can’t find the right label to correct the translation.

5) Add to cart hover button that shows up on miniature ignores two very important Prestashop options - when I want not to show the button because of product attributes (Preferences > Product section) and when the product stock is 0 but the product is visible. Those situations makes modal window for adding to cart empty and makes no sense. The button shouldn’t be there in those two situations.

6) Product stock is hidden no matter the options - they should be visible if I want to.

7) Add / substract (+/- 1) in side of “add do cart” od product page are also hidden - I frankly don’t know why I should give that option away from my clients :)

8) SUGGESTION: Would it be possible to add a heading right above product attributes on product page? I would like to emphasize the fact that client should choose the right variant with a heading - something like “Choose your variant” or something like that.

9) Is it possible to turn of Product Details tab by default when there are no product features?

10) On cart page breadcrumbs shows no cart link - only home.

OK, that is all :)

Some of them are quite urgent so I’m choosing high priority, hope it’s ok.

Best,
Damian

Comments

Damian Lewandowicz 24 Oct 2017, 10:00

Update:

Number 3) is no longer a problem at the moment.
I will monitor the issue.

Marek 24 Oct 2017, 16:17

Hi, Damian.
1. Could you please take a screenshot
2. Go to “International” > “Translations” find “pk_flexmenu” and translate it

Damian Lewandowicz 24 Oct 2017, 17:20

Ad:1) In the screenshot you can see that “product-actions” div has top padding instead of top positioning making it overlay the link - this whole padding area is therefor NOT clickable.
Ad:2) Solved, thanks.

Waiting for your info about problems 4-10 :)

Marek 25 Oct 2017, 11:01

1. Try this:

body .highlighted-product .product-miniature .product-action {padding:0; top:25%}

4. Could you please enable Layered module to see the issue?

Damian Lewandowicz 25 Oct 2017, 15:01

Ad:1) CSS code helped.

Ad:4) Module is enabled, you can check it right here for example: http://sklep.ekgroup.pl/211-gniazda-i-laczniki (the shop is offline, but your IP should be still add to exceptions and your admin access is also available)

Marek 26 Oct 2017, 11:16

Hi, Damian.
Sorry for the delay. I have a lot of work these days.
4a. Yes, I see. H1 tag has been removed
4b. Just try to use search in your BO to find “Active filters” 5. Please give me a product in your shop which I could test.

Damian Lewandowicz 26 Oct 2017, 13:12

4b) I still can’t find it. I searched in modules, in theme, in other translations - nothing :( Did you try to find it in different shop?

5) In category below, almost every product has combinations and most of them has 0 stock. Unfortunately add to cart button is still active making the modal window empty and nothing happens.
http://sklep.ekgroup.pl/45-smc-seria-kq2-standard

Another example is here: http://sklep.ekgroup.pl/204-laczniki-systemu-45x45 These are simple products with stock 0.

This is when it comes to stock.

When it comes to product with combinations that are on stock, the button adds to cart the default combination but I DON’T WANT this to happen. This assortment is very specific and the client needs to know exactly what he chooses.

To sum up: add to cart button needs to be faded out in two circumstances:
1) when the product stock is 0
2) when the product has combinations (of course if I choose such option in Preferences > Product section.)

Marek 27 Oct 2017, 12:09

4b. Now I understand. Try to search it under the domain Shop.Theme.Global
media.promokit.euscreenshotsscreencloudscreenshot20171027_114440.jpg 5. I just added condition if $product.availability == ‘unavailable’ to not show the button, please check out how it works now
6. Where exactly product stock is hidden?
7. I’ll make it work in the next theme version

Damian Lewandowicz 27 Oct 2017, 12:30

Ad:4) Solved. The translation WAS correct but it needed cleaning.

Ad:5) I think it’s ok with unavailable products. What about the condition when product has combinations?

Ad:6) Well maybe it’s not exactly hidden, maybe it’s a 1.7 core feature, but the available stock is only seen in additional information tab. We need to give my clients that information right at the top - for example together with availability information.

Ad:7) OK.

Marek 27 Oct 2017, 12:42

Do you want to hide Add to cart button if a product has combinations?

Damian Lewandowicz 27 Oct 2017, 14:12

Well, since there is an core options for this in PS (see the screenshot or go to Preferences > Product section.) yes, I need the have such possibility :)

Marek 27 Oct 2017, 15:21

Yes, I see now. I’ll try to make it soon

Damian Lewandowicz 27 Oct 2017, 16:31

OK, cool. To sum up, this is what we have now:

1 ) SOLVED.

2 ) SOLVED, but the problem returned :( I did translate the mobile flexmenu label but it came back, I don’t know why…

3 ) SOLVED.

4 ) SOLVED.

5 ) HALF SOLVED - waiting for additional developments with add to cart button.

6 ) WAITING.

7 ) WAITING FOR THEME UPDATE.

8 ) WAITING.

9 ) NEVERMIND - NO LONGER CURRENT

10 ) WAITING - and I saw that the problem is not only on cart page but also for example on my account page and so on. Those pages should have valid breadcrumbs.

11) NEW PROBLEM: I would like to add Material Design icons via

<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

but it doesn’t save when I try to write this in custom JS. Does this custom section accept only JS entries? Maybe instead of custom JS there could be just custom section that is added to theme HEAD?

Marek 28 Oct 2017, 00:36

2. I don’t have access to translation section in your BO to check out the issue
5. I just found that option is related to the Product page. Look at this http://awesomescreenshot.com/03f6e3uz34

Damian Lewandowicz 29 Oct 2017, 07:30

Ad:2) I just added this access to you.

Ad:5) Marek, think about it for a second :) It wouldn’t make any sense. Why would you turn off add to cart button on product page where you see the chosen variation? :) Besides, in PS 1.5 there is same option and it explicitly says it considers category view and so on. I’m sure in 1.7 it works the same way.

Marek 29 Oct 2017, 11:24

2. As I can see the word “menu” is translated. Have you tried to clean prestashop cache?
5. There is no my code modification on the product page. It works like default prestashop theme

Damian Lewandowicz 29 Oct 2017, 13:36

Ad:2) Yes, I did :(

Ad:5) Marek, again, this option DOES not consider product page. It’s about “add to cart” button on category pages. So it’s about those product actions buttons you give. Do you really want me to install fresh PS to show you this? This option DOES NOT makes any sense on product page. I know it’s under “product page” section, but it’s also there in PS 1.5 and there it tells clearly it’s about product minitaures in category for example.

Marek 30 Oct 2017, 17:44

2. I have no idea about translation. Try to translate it directly in the file pk_flexmenu.tpl
5. Here is freshly installed prestashop with native theme and disabled add to cart button http://awesomescreenshot.com/0846e4yz37 http://compare.promokit.eu/3-women

Damian Lewandowicz 30 Oct 2017, 22:36

Ad:2) Crap :( But that will be deleted as soon as first update, right?

Ad:5) OK, I see. So it seems this options is just plain fucking bugged, as it does NOTHING whatsoever, right? :( Are you nonetheless able to add this as an option to theme, a condition that hides add to cart button if the product has variants?

Marek 30 Oct 2017, 22:37

2. I have an idea, give me a time.
5. yes, it seems like a bug. I’ll try to find a condition into the code to hide it.

Marek 31 Oct 2017, 00:23

2. Fixed by changing translation domain
5. Fixed too

Damian Lewandowicz 31 Oct 2017, 07:25

Well that was fast :)

I see the fixed translation, but don’t see the effect of hidden add to cart button on products with combinations - is this fix live on my site or is it something that will go in the next update?

Marek 31 Oct 2017, 09:40

I have tested it locally and added working condition to your shop, so it should work

Damian Lewandowicz 31 Oct 2017, 13:36

I’ll check it and let you know.

Damian Lewandowicz 02 Nov 2017, 09:08

I’m still seeing add-to-cart button: see here: http://sklep.ekgroup.pl/242-czujniki-i-wylaczniki-krancowe - almost all those products have combinations and the button is still there

Marek 02 Nov 2017, 11:09

Try now

Damian Lewandowicz 02 Nov 2017, 11:43

OK, it sees to work now, thanks :) All those changes will be still there after theme update?

I’m also waiting for the other problems :)

Marek 02 Nov 2017, 11:57

Yes, that fix will be available in the next theme version.
10. I just checked out default Prestashop theme and there is no breadcrumb on cart page at all. So if you want I could remove it for you too.
11. Instead of that line of code, use custom CSS

/* fallback */
@font-face {
  font-family: 'Material Icons';
  font-style: normal;
  font-weight: 400;
  src: url(https://fonts.gstatic.com/s/materialicons/v31/2fcrYFNaTjcS6g4U3t-Y5UEw0lE80llgEseQY3FEmqw.woff2) format('woff2');
}

.material-icons {
  font-family: 'Material Icons';
  font-weight: normal;
  font-style: normal;
  font-size: 24px;
  line-height: 1;
  letter-spacing: normal;
  text-transform: none;
  display: inline-block;
  white-space: nowrap;
  word-wrap: normal;
  direction: ltr;
  text-rendering: optimizeLegibility;
  -webkit-font-smoothing: antialiased;
}
Damian Lewandowicz 03 Nov 2017, 14:19

Ad:10) OK, I’ll removed it myself.

Ad:11) I will try that and let you know.

Damian Lewandowicz 06 Nov 2017, 09:41

OK, it seems to work, thanks.

We have two problems left I guess :)

8 ) SUGGESTION: Would it be possible to add a heading right above product attributes on product page (see screenshot)? I would like to emphasize the fact that client should choose the right variant with a heading - something like “Choose your variant” or something like that.
9 ) Is it possible to turn of Product Details tab by default when there are no product features?

Marek 06 Nov 2017, 11:36

8. I suppose the best way for you to create and use child theme where you could customize your theme and don’t worry your customizations will be erased after an update. Read more about that http://developers.prestashop.com/themes/smarty/parent-child-feature.html

9. Yes, it’s possible, but again, it requires customization.

Damian Lewandowicz 06 Nov 2017, 11:38

Ad:8 ) OK, I’ll check this out.

Ad:9 ) And what do YOU think about that? Maybe something to implement in next theme update? :) It’s no use to have en empty tab on product page after all, am I right? :)

Marek 06 Nov 2017, 11:42

9. wait a moment, I’ll check

Marek 06 Nov 2017, 11:54

Could you please give me a link to product with empty product details section?

Marek 06 Nov 2017, 17:09

As I can see the tab is not really empty. There is some hidden information. If you want I can unhide it
https://www.dropbox.com/s/hbbgdw7zmoqx9la/Screenshot%202017-11-06%2017.08.36.png?dl=0

Damian Lewandowicz 07 Nov 2017, 07:42

Well, you did hide them for a reason, right? All those - except stock quantity - are available in top section of a product. I also don’t want those data to be in additional tab.

This also reminds me that we skipped problem no. 6 - that product stock is no visible in product top section.

What i would really want is this:
a) Move stock quantity to top section - for example somewhere around add to cart button.
b) Hide additional info tab when there are no features to show.

Would that be possible to do?

Marek 07 Nov 2017, 11:19

a. I already tried that, but it’s not updating when you change combinations.
b. Unfortunately, I can’t detect empty tab to hide it.

Damian Lewandowicz 07 Nov 2017, 11:24

a) Can’t you copy the code that is in the additional info tab? Because there quantity changes due to chosen variation - I just checked.
b) OK.

Marek 07 Nov 2017, 11:24

No problem to copy it. I’ll do that for you right now

Marek 07 Nov 2017, 11:38

Done.
I also add a script what hides tab if it’s empty

Damian Lewandowicz 07 Nov 2017, 12:11

:)

Maybe I’m exaggerating, but I think my tickets makes you develop theme to more and more awesome state ;)

Marek 07 Nov 2017, 12:12

Yes, right :)

Damian Lewandowicz 07 Nov 2017, 12:14

:)

Give me a couple of days, before closing the ticket, ok?
I’m in a middle of something, and I want to check if I have anything else to suggest.