• Priority: 0
  • Status: Closed
  • Theme: Alysum
  • Assigned To: Marek
  • Private: No
  • Open Date: 11.04.19, 17:00
  • Opened by:
  • Closed by: Marek
  • Closed on: 25.04.19, 15:04
  • Reason: Closed
  • Comment: Glad to help!

Ticket #14246 - few problems

Hello,

i have a few problems:
1. i want to add “add too favorite” in product page on mobile
2. make amp url more friendly, like desktop url
3. newsletter form doesn’t work (i can’t write in desktop version, can’t subscribe to mobile version)
4. gdpr consents doesn’t appear in mobile (i use prestashop gdpr module)

Thanks

Comments

Marek 11 Apr 2019, 22:31

1. There is no Favorite products AMP yet, we are planning to add it in further updates
2. AMP URLs for main pages like homepage, category and product are friendly
3. We will check it out
4. Yes, we also add that as soon as possible

12 Apr 2019, 10:14

Hello,
1, 4: ok, i will wait for it :)
2:
Mine look’s like https://www.smarthomedevices.ro/mobile/product/21, i want it to look like original url, from desktop (https://www.smarthomedevices.ro/prize-wireless-inteligente-sonoff/21-priza-inteligenta-wireless-sonoff-s20.html)

Marek 13 Apr 2019, 16:08

It’s impossible to have the same url because it’s two different pages

14 Apr 2019, 11:25

ok :) but we can rename it like https://www.smarthomedevices.ro/mobile/prize-wireless-inteligente-sonoff/21-priza-inteligenta-wireless-sonoff-s20 ? or https://www.smarthomedevices.ro/mobile/21-priza-inteligenta-wireless-sonoff-s20 ?
is there a code like id-rewrite for default ps url?

Also, on android, with chrome, account animation doesn’t work, and on iPhone is very little (if you will try it with chrome or firefox browsers from desktop, it works, but just on firefox is at the original width/height…)

how about newsletter problem?

thanks for help :)

14 Apr 2019, 16:19

hello Marek,

is there an option to enable product reviews tab on product page, and product flags “new” and “reduced price” on product thumbnails in mobile version?

14 Apr 2019, 16:29

sorry, product flags on product thumbnails on home page and category page, and product flags “new” also in product page, now i can see just in product page: reduced price and percentage

Marek 15 Apr 2019, 12:54

Hi, Gabriel.
1. Yes, we can try to change product URLs in the next update
2. Animation seems doesn’t because there is no space to show an icon. You can add “min-height” property for that icon, like this:

.user-preview amp-bodymovin-animation {min-height:50px}

3. For now, there is no such option to have reviews tab, but it’s in our TODO list for further versions
4. I’ll check it out

15 Apr 2019, 18:26

4. with flags (product labels) i have fixed some issue, but i don’t figure it out how to edit on category page (https://www.smarthomedevices.ro/mobile/category/36). i want it to look like flags from product page https://www.smarthomedevices.ro/mobile/product/21) everywhere :) and where is “Out of stock” (”stoc epuizat” in romanian), to be “in supplier stock”, and “in supplier stock” to appear in every product thumbnail that have set stock 0(here is an example with product set to “in supplier stock” https://www.smarthomedevices.ro/mobile/product/22)

2. thanks, i fixed it
1, 3. i will wait fo it

Thanks

Marek 16 Apr 2019, 14:21

I have added labels in the file /public_html/themes/alysum/templates/mobile/catalog/_partials/miniatures/product-miniature.tpl

16 Apr 2019, 14:28

thanks a lot :)

in /public_html/themes/alysum/templates/mobile/catalog/_partials/miniatures/product-miniature.tpl i put the code below to show reduced price on home page and category page, but is doesn’t appear. i also tried with {literal}regular_price{/literal} and {literal}{regular_price}{/literal}, {literal}regular_price{/literal} and {literal}product.regular_price{/literal} and it shows “null”. is another code for this tag?

{if !$configuration.is_catalog}
<div class="product-price-amp price m15">
          <div class="product-price-and-shipping">
    {literal}{{#has_discount}}{/literal}
    <span class="discount-price">
      <span class="regular-price">{literal}{{regular_price}}{/literal}</span>
    </span>
    {literal}{{/has_discount}}{/literal}
    <span class="price">{literal}{{price}}{/literal}</span>
  </div></div>
  {/if}
16 Apr 2019, 14:34

about last message, i succeeded with “reduced-price”: “{/literal}{$product.regular_price_amount}{literal}”

thanks a lot for your support :)

Marek 16 Apr 2019, 14:41

You are welcome!

17 Apr 2019, 22:05

Hello Marek,

i have changed my store domain. now is https://www.1smart.ro/ (for ps BO is same data, but with https://www.1smart.ro/adminshd

how about newsletter problem?

18 Apr 2019, 10:08

Hi,

now i can type, but “submit” doesn’t work. if i press enter, the page is refreshing.. :(

Marek 18 Apr 2019, 10:58

You missed last step

Open the file /modules/pspagebuilder/views/templates/front/widgets/widget_newsletter.tpl

find

value="submit" 

replace with

value=""
18 Apr 2019, 11:03

i have do that :)

{*
* Promokit Newsletter Widget
*
* @package pspagebuilder
* @version 5.0
* @author https://promokit.eu * @copyright Copyright (C) 2018 promokit.eu <@email:support@promokit.eu>
* @license GNU General Public License version 2
*}
<div class=”block pts-newsletter {$addition_cls}{if isset($stylecls) && $stylecls} block-{$stylecls}{else} block-borderbox{/if}”>

  {if isset($widget_heading) && !empty($widget_heading)}
      {include file="_partials/heading.tpl" title={$widget_heading}}
  {/if}
  <div class="widget-inner block_content{if isset($content_alignment)} {$content_alignment}{/if}">
  <form action="{$urls.base_url}" method="post" class="newsletter-form relative flex-container">
      <input class="newsletter-input form-control" id="newsletter-input-footer" type="email" name="email_wdg" placeholder="{l s='Your email address' mod='pspagebuilder'}" required="required" value="" />
      <label for="newsletter-input-footer" aria-label="{l s='Your email address' mod='pspagebuilder'}"></label>
      <input type="hidden" name="action_wdg" value="0" />
      <button class="submit-widget-newsletter">
          <svg class="svgic svgic-right-arrow-thin"><use xlink:href="#si-right-arrow-thin"></use></svg>
      </button>
  </form>
  {if $information}
      {$information}
  {/if}
  {if isset($alert)}
  <div class="alert {$classalert}">{$alert}</div>
  {/if}
  </div>

</div>

18 Apr 2019, 11:06

still doesnt work

in /public_html/modules/pspagebuilder/views/templates/front/widgets/widget_newsletter.tpl i have set valuea=””

Marek 18 Apr 2019, 13:50

I just find out you are using module instead if widget. I have make a fix for a module but there is another issue. You server blocks Ajax requests to the module file, I see the following error

Warning: escapeshellcmd() has been disabled for security reasons

See screenshot http://take.ms/i56Bx Please contact your server support and ask to fix that

19 Apr 2019, 21:07

Hi Marek

i have used seo & traffic section for rewrite url for pk-amp url like “module-pk_favorites-account” (module-pk_favorites-account Favorite produse-favorite). The problem is after i done with all renaming, new page is redirect to responsive variant of desktop site, not amp..

for module-pk_amp-cart (module-pk_amp-cart Cos de cumparaturi cos-de-cumparaturi) is working fine..

i taked a look on google aboyt this, bi=ut i can’t find anything..

and, for category and product pages, if i change “href get: id_category” with category_name or whatever category name controller it is, it will work fine? if not, can you tell me an ETA for next theme update with “category and products name” in url for amp?

if you need to modify something, tell me and i will back-up my store, and then you can modify :)
my site is still in work (demo), so i work on it everyday a lil’ bit :)

Thanks a lot :)

Marek 21 Apr 2019, 23:03

1. AMP pages of Favourites module doesn’t exist yet
2. We are working on update. You can see our changeling with TODO list here https://alysum5.promokit.eu/themes/alysum/assets/changelog.html

22 Apr 2019, 17:40

Hi,

thanks for info! :)

favorites link was just an example, another example is https://www.1smart.ro/istoric-comenzi (order-history)

for cms pages is any chance to make it look like desktop ulr? i found url rewrite in “seo and traffic”, but it change just “cms” (https://www.1smart.ro/info?id_cms=9). i will like it to be cms id and cms page name (https://www.1smart.ro/info/9-cum-platesc).

can you ampify product reviews and product & category page in this update? :)
i understand that u have a lot of word to do :)

thanks a lot for your patience

Marek 23 Apr 2019, 12:19

It’s impossible to have the same ink, because that is two different pages. The only one way is to disable AMP for some pages to have one link.
Product Reviews will be ampified but what “product & category page” do you mean?

23 Apr 2019, 13:31

@cms page: it may be different, but at least show the name of the cms page
example: desktop: https://www.1smart.ro/info/9-cum-platesc

       Mobile: https://www.1smart.ro/mobile/info/9-cum-platesc or something like that

@product & category page: i want mean pages for product and category to look like in the example above or https://www.1smart.ro/mobile/prize-wireless-inteligente-sonoff/21-priza-inteligenta-wireless-sonoff-s20.html ( prize-wireless-inteligente-sonoff = category name; 21-priza-inteligenta-wireless-sonoff-s20 = id and product name)

i don’t like to have url with “/module/pk_amp/” in site. that’s my problem :) if you take a look in my BO - traffic % seo, you will see that i have rename some url with “/module/pk_amp/”, but it doesn’t work for all

i will try to rename it again, and then I’ll send you a list of what I did not go through

Marek 23 Apr 2019, 14:08

The link shows 404 error https://www.1smart.ro/mobile/info/9-cum-platesc

I understand the problem, but AMP is separated theme version and it has his own links

23 Apr 2019, 18:26

this was just an example like i wish to appear,
now, cms url for mobile looks like https://www.1smart.ro/info?id_cms=9

Marek 23 Apr 2019, 22:37

Yes, CMS page has no pretty URL‘s but we are going to add it in further updates

24 Apr 2019, 21:08

ok, but you can tell me what i need to change to have pretty url for cms? i want to try

i think you understand me, i don’t want my site to be crawled by google with this url :)

24 Apr 2019, 23:07

i have a problem, i can’t edit in pagebuilder default profile. if i try to export and import it, it give me an error..
i doesn’t use if after i changed theme name.. it can be that?

Marek 25 Apr 2019, 11:58

1. I just add pretty URL for CMS pages https://www.1smart.ro/mobile/page/9-cum-platesc

2. Try this solution for Page Builder https://alysum5.promokit.eu/promokit/documentation/#faq13

25 Apr 2019, 12:43

thank you! :)

@cms: if i want to change /page/ with /info/ where i need to search/edit?

Marek 25 Apr 2019, 13:55

In the file /modules/pk_amp/pk_amp.php

25 Apr 2019, 14:20

thanks