• Priority: 0
  • Status: Closed
  • Theme: Alysum
  • Assigned To: Marek
  • Private: No
  • Open Date: 06.05.19, 20:58
  • Opened by: Piotr Pluta
  • Closed by: Marek
  • Closed on: 02.07.19, 21:54
  • Reason: Closed
  • Comment: Pagination is available for AMP blog

Ticket #14431 - Blog AMP

Hello,

1. I did the update theme, I see in the changelog that the blog now works in amp but I do not see it. There is no redirection, see https://beta.monvelli.pl/blog - How it’s working ?

2. After the template update there is a problem with loading images. Please see hera https://beta.monvelli.pl/sukienki and the click to page 2 on the pagination

it seems to me that when updating, I have a mess with hooks. Do you have any way to check if I have registered all appropriate hooks?

Comments

Marek 07 May 2019, 14:38

The issue has been fixed. Please check it out

Piotr Pluta 07 May 2019, 16:56

What url is of blog in amp ?

Piotr Pluta 07 May 2019, 18:00

1. it is possible change url to https://beta.monvelli.pl/mobile/blog ?

it seems to me that this blog is still underdeveloped under the amp

1. no tag meta <link rel=”amphtml” …… 2. no redirection when we enter the website https://beta.monvelli.pl/blog from the phone
3. When we are on the blog page in amp https://beta.monvelli.pl/module/pk_amp/blog and then click read more in a single post it switches us into the normal version
4. https://beta.monvelli.pl/module/pk_amp/blog i see a html code in lead post

Marek 07 May 2019, 19:51

We will try to implement all these notices as soon as possible

Piotr Pluta 11 May 2019, 20:21

any progress ?

Marek 12 May 2019, 18:32

1. I have it in our TODO
1. https://take.ms/50or1

2. When I open the page https://beta.monvelli.pl/blog on mobile it redirects me to https://beta.monvelli.pl/module/pk_amp/blog

3. Fixed
4. Fixed

Piotr Pluta 14 May 2019, 15:19

Thanks for the corrections.

1. I think that it would be better if the link to the single post and other blog links were to amp version , no normal site. This is an additional unnecessary redirection. http://prntscr.com/nof0vx 2. Could tou tell me why single post image are not showing https://beta.monvelli.pl/module/pk_amp/blogSingle?rewrite=co-ubrac-do-sukienki-na-ramiaczkach&fc=module ?

Marek 14 May 2019, 21:47

1. Yes, right
2. as I can see there are wrong width and height parameters (8×8). Please check it out in the post settings

Piotr Pluta 16 May 2019, 12:39

1. So,when you have plan to improve it?
2.My settings is ok. I found bug http://prntscr.com/npb2qu, here is a fix http://prntscr.com/npbfs3 (First assigns a string and then an array).

https://beta.monvelli.pl/module/pk_amp/blogSingle?rewrite=co-ubrac-do-sukienki-na-ramiaczkach&fc=module

Now it’s a bit better but why the picture does not scale up to the screen size of the device.

Please see http://prntscr.com/npbfjw

Marek 16 May 2019, 17:30

1. In June
2. Could you please send me fixed file, I’ll compare them
3. Here is missed parameter https://take.ms/kcPQj

Piotr Pluta 20 May 2019, 21:00

1. Ok
2. In attachments
3. OK, thanks

Piotr Pluta 21 May 2019, 11:48

What about pagination on the blog ? It seems that this functionality are missing.

Marek 23 May 2019, 14:38

Yes, I’ll add this to our TODO to add it in the next update