• Priority: 0
  • Status: Closed
  • Theme: Alysum
  • Assigned To: Marek
  • Private: No
  • Open Date: 13.06.19, 19:56
  • Opened by: Jacek Szczurek
  • Closed by: Marek
  • Closed on: 17.06.19, 22:40
  • Reason: Closed
  • Comment: Glad to help!

Ticket #14833 - Newsletter not submiting

Hi,

found problem in pspagebuilder module, after placing newsletter form into footer, e-mail adress is not submiting.

Problem can be found into /modules/pspagebuilder/views/js/pagebuilder.js, on document.ready() function .submit-widget-newsletter’ click event is not getting subscribed, which causes problem.
i already found work around with event delegating e.g ($(document).on(’click’, ‘.submit-widget-newsletter’, function(e))

2nd and 3rd problem is IsEmail function is missing (can be found into js), same as pkPopUp

4th problem is missing translation for newsletter validation / success problem can be found here : /modules/pspagebuilder/classes/widget/newsletter.php method newsletterAjaxRegistration where responses are hard coded

Comments

Jacek Szczurek 14 Jun 2019, 07:47

Also GDPR consent is missing (checkbox)

Marek 14 Jun 2019, 13:25

1. I see you have customized notifications for the newsletter and it seems works fine
2. “isEmail” function located in the file /themes/alysum/assets/js/alysum.js
4. I can’t find hardcoded translations, could you please take a screenshot?

Jacek Szczurek 14 Jun 2019, 13:42

i belive its hardcoded, added translation and its not avaible at my custom popup

2) should i add gdpr checkbox, or captcha by my self? or it is avaible in module?

Marek 17 Jun 2019, 16:39

That is a standard of translatable phrases in PrestaShop

$this->l('Subscription successful')

Hardcoded looks like a plain text

Subscription successful

Try to change the translation somehow just to see if it works


there is no such option yet, but it’s in our TODO to add in the next update