• Priority: Medium
  • Status: Closed
  • Closed by: Marek (marek)
  • Closed on: 30.08.19, 12:36
  • Reason: Closed
  • Comment: Glad to help!

Ticket #15176 - AMP Issue from google

Hi Marek, just got an email from google that there’s an issue with the AMP. I have attached email from them. Do you know what does this mean and what we need to do with that?

This ticket does not depend on any other tickets.

Marek (marek) 23 Jul 2019, 17:32

The error says that some page contains non-compatible with AMP image tag.
just disable AMP for a while. We will back to this issue when all will be properly configured

Lisa Keeling (Lissea) 13 Aug 2019, 13:48

Hi Marek,

We have finally configured AMP so probably we can get back to that issue.

There is a bunch of issues listed in our Google Search Console related to AMP. See image. If you need access to it, I would probably need to share each error individually.

Please note - the issue refers our live site, so whatever you will do in files, i'd need to know what to copy over to our production instance.

Marek (marek) 13 Aug 2019, 14:08

Hi, Lisa.
We have developed AMP valid for google.
All errors what appears there comes from the content, like product description, some custom texts, etc.. The source code of the texts must be clear and valid

Lisa Keeling (Lissea) 13 Aug 2019, 14:41

Hi Marek,

That's strange as I reported the issue before we even started messing around with the code. We got that email just after you uploaded the module. So I get that some changes we've made might have caused some google issues, but the image tag issue I reported in the first place was there from the beginning.

Marek (marek) 14 Aug 2019, 10:49

Here is an example of invalid code https://take.ms/Pa55M please do not edit .tpl file, or read AMP HTML Specification https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/ to do that correctly

Lisa Keeling (Lissea) 16 Aug 2019, 15:22

Hi Marek,

I've been reading about the AMP requirements and as far as I got - scripts are not allowed with AMP.
I contacted Mailchimp (one of the code you pointed to is our newsletter pop up) and they aren't familiar with AMP format so I really don't know (based even on specification you've sent) how to change this script to be AMP compatible.

Marek (marek) 16 Aug 2019, 15:36

Where do you need to have the Mailchimp module? At a product page?

Lisa Keeling (Lissea) 16 Aug 2019, 15:41

the script that has been added to head.tpl is our pop up form. It appears once in a while to our customers, usually on homepage.

the script:
<script type="text/javascript" src="//downloads.mailchimp.com/js/signup-forms/popup/unique-methods/embed.js" data-dojo-config="usePlainJson: true, isDebug: false"></script><script type="text/javascript">window.dojoRequire(["mojo/signup-forms/Loader"], function(L) { L.start({"baseUrl":"mc.us20.list-manage.com","uuid":"4c61507a1752098eee6a63e07","lid":"79bb5a8f91","uniqueMethods":true}) })</script>

The thing is - the pop up works both on desktop and mobile but we are getting those google errors that custom java script isn't allowed. It's basically what you've sent here - https://take.ms/Pa55M

Marek (marek) 16 Aug 2019, 16:43

Yes, you can't use any custom JS code. But we have implemented Mailalerts module form for the product page so it should work by default

Loading...