• Priority: 0
  • Status: Closed
  • Theme: Alysum
  • Assigned To: Fred
  • Private: No
  • Open Date: 17.11.19, 20:56
  • Opened by: Marco Montanari
  • Closed by: Fred
  • Closed on: 03.01.20, 14:17
  • Reason: Closed
  • Comment: Glad to help!

Comments

Fred 18 Nov 2019, 10:20

All those scripts has “async” attribute which is more important then minifying all files to one. Prestashop doesn’t minify files with that attribute

Marco Montanari 18 Nov 2019, 10:29

Sorry but Minify a css or a js is not the same thing to put async to a .js
Async helpt the loading of the resource to be loaded in better way.

Minify a js means you save Kbytes and speed up the load of the library
Minify not meant “combinate” or “join” more js in one, that is another story and anyway have less js or css will make less http calls to external libs.

Your JS script must be Minified to save kb on loading even if all are separated and with async.

Fred 18 Nov 2019, 16:57

I know what minisication and “async” means. A lot of people before asked to add “async” for theme’s scripts what we implemented. Now you ask to remove that option, so we can add a toggle to the theme settings to disable “async” but it will be ready in the next release, not right now

Marco Montanari 18 Nov 2019, 17:54

Hi Fred, i think there is a misunderstanding.

What i simply ask is to use ph_simpleblog-17.min.js instead of ph_simpleblog-17.js
Please minify the scripts in your distribution
The async is fine! ;)

Fred 20 Nov 2019, 19:45

I see now.
We are working on that in the next 5.3.9 version

Fred 21 Nov 2019, 00:08

This feature already implemented in our demo and will be available in the next update

Marco Montanari 21 Nov 2019, 10:11

thanks!