Ticket #17465 - Product Miniature showing shoe sizes (based on defined Features) even when sizes are out of stock
Hello
Shoe sizes are shown with product miniature on category page (see image below) even though specific sizes are out of stock in their respective combinations:
Product combinations defined as in the image below:
We will require NOT TO SHOW such shoe sizes where stock is zero.
Thank you, can you please do it? It doesn’t make sense to show to the cutomer something that is not available. This was a primary reason why we purchased the theme and verified this unctionality upfront multiple times.
Fred, have you tried signing in with alysum.modules.obuvtopky.sk username (it’s different!)? I granted access to modules root folder for that username. when will be next template release available to upgrade?
Hello Fred, thank you but this is NOT ACCEPTABLE solution because changes will be lost with next theme update. I reverted your changes in root module folder /modules/pk_themesettings/pk_themesettings.php
I checked that you changed only one function. Can you please implement the changes into child theme directory for this function only:
yes but I don’t know why. I didn’t do anything with JS. can it be that a version of blog module which you recommended in one of the threads has caused some problems?
It should work fine. and captcha also works in blog demo. Try to make a fix yourself. - Open the file /modules/ph_simpleblog/views/js/ph_simpleblog-17.js - remove the line 102 https://take.ms/k4uqW
Solution proposed on 23 May 2020, 08:29 is in place but doesn’t work. Shoe sizes are shown with product miniature on category page (see image below) even though specific sizes are out of stock in their respective combinations.
You can check with any random product that doesn’t have defined she size (combination) but stock 0.
Can you please implement a solution in alysumchild directory or overrides directory so it’s permanent and works after next upgrade. many thanks
But you know what file I have updated /pk_themesettings/pk_themesettings.php and what code was changed https://take.ms/NQx8W you can do all yourself, there is only one line you have to add
I just changed this code https://take.ms/4ibh6 in the file /pk_themesettings/pk_themesettings.php what I already described you earlier. Now all works. Please don’t change that file, I can’t do the same work twice
We care about your privacy.Use the list below to configure your privacy settings
These cookies are necessary for the website to function and cannot be switched off in our systems. They are usually only set in response to actions made by you which amount to a request for services, such as setting your privacy preferences, logging in or filling in forms.
You can set your browser to block or alert you about these cookies, but some parts of the site will not then work. These cookies do not store any personally identifiable information. Read more about cookies in our Privacy Policy
The collection of information about your use of the website used to measure, understand, and report on your usage of the service, only in case of some error appearing. All collected information will be automatically removed from our server every month or immediately after your request.
Allow us to collect details to access your server and your website admin panel. This information will be requested from you only if it will be really necessary to provide requested by you an action like fix a bug or configure website. All provided information will be removed from our server by your request.
Please take a moment...
to read about the Privacy Policy we use with this website. Click "Privacy Options" to configure how we can interact with you and your device or computer.
Comments
There is no such option. We have to customize this feature to make it work as you like
Thank you, can you please do it? It doesn’t make sense to show to the cutomer something that is not available. This was a primary reason why we purchased the theme and verified this unctionality upfront multiple times.
we have huge ticket number last days. Please remind me about that within a week, maybe we will have time
for this particular case, next week is OK
ok
Hi Fred, let me know when you can start working on this. You mentioned sometimes this week
I need access to modules files on your server
ok, which folder exactly. is it this one?
no, /obuvtopky.sk/web/modules/
again, we need to use parent-child principle here as nothing should be changed is /obuvtopky.sk/web/modules/.
can you please work in child folder where you have access.
Regards, Peter
it’s impossible. I need to edit .php files. but in the directory /alysumchild/modules/ only .tpl files are allowed
Hi Fred, I granted you privileges to the folder
please use this account to access, passwords and server stay the same as defined in my profile here
please create a backup copy of each file before editing with suffix
Please acknowledge this.
still don’t see “modules” folder.
But we fixed this issue and it will be available in the next update
Fred, have you tried signing in with alysum.modules.obuvtopky.sk username (it’s different!)? I granted access to modules root folder for that username. when will be next template release available to upgrade?
Now it has to work as you asked. Updated file is /pk_themesettings/pk_themesettings.php
Hello Fred, thank you but this is NOT ACCEPTABLE solution because changes will be lost with next theme update. I reverted your changes in root module folder /modules/pk_themesettings/pk_themesettings.php
I checked that you changed only one function. Can you please implement the changes into child theme directory for this function only:
it’s impossible. we can only override .tpl files with child theme
is there any other solution? how about using directory:
I want to prevent this not working with next upgrade
Hello Fred, this stopped working and I don’t entirely know why but maybe due to forced regeneration of the theme.
Can you please implement permanent solution into child theme as requested originally? Many thanks.
for some reason .js files won’t override modules original files, you can try yourself
yes but I don’t know why. I didn’t do anything with JS. can it be that a version of blog module which you recommended in one of the threads has caused some problems?
It should work fine. and captcha also works in blog demo.
Try to make a fix yourself.
- Open the file /modules/ph_simpleblog/views/js/ph_simpleblog-17.js
- remove the line 102 https://take.ms/k4uqW
Hello Fred, this stopped working and I don’t entirely know why but maybe due to forced regeneration of the theme.
Can you please implement permanent solution into child theme as requested originally? Many thanks.
what stopped working?
Solution proposed on 23 May 2020, 08:29 is in place but doesn’t work. Shoe sizes are shown with product miniature on category page (see image below) even though specific sizes are out of stock in their respective combinations.
You can check with any random product that doesn’t have defined she size (combination) but stock 0.
Can you please implement a solution in alysumchild directory or overrides directory so it’s permanent and works after next upgrade. many thanks
But you know what file I have updated /pk_themesettings/pk_themesettings.php and what code was changed https://take.ms/NQx8W you can do all yourself, there is only one line you have to add
hello fred - again can this be updated in the alysumchild directory, not in the main modules directory.
with the child theme possible to override only template files (.tpl) read more here https://devdocs.prestashop.com/1.7/themes/reference/template-inheritance/parent-child-feature/
can JS be placed in overrides or somewhere else?
Ye, it is
ok can you please solve by using overides or something else as you confirmed. this is still not working. many thanks.
I just changed this code https://take.ms/4ibh6 in the file /pk_themesettings/pk_themesettings.php what I already described you earlier. Now all works. Please don’t change that file, I can’t do the same work twice