• Priority: 0
  • Status: Closed
  • Theme: Alysum
  • Assigned To: Fred
  • Private: No
  • Open Date: 10.05.20, 19:52
  • Opened by: Marco Montanari
  • Closed by: Anonymous Submitter
  • Closed on:
  • Reason: Not a bug

Ticket #17790 - Upgrade from 5.4.1 to 5.5.0 problems

the main problem is the k_themesettings that is still there and pkthemesettings is not installed.

After manually copy the module & theme to the root as explained in manual guide the pkthemesettings is nto detected by the system

if i zip pkthemesettings.zip and try to upload it gave an error and is not installed.

Without pkthemesettings miniature not loading plu smany other theme problem.

I still testing the 5.5.0 in local to ne sure that new bugs will not kill my Product server.

Thanks.

Comments

Marco Montanari 10 May 2020, 20:29

miniature infinite load: https://gyazo.com/1a714cfac5eef147a73514ef8384a32a


theme settings not upgraded: https://gyazo.com/0b41d537cb7f241eeddb6fbc03bc6dff


AMP - Error in each product detail page and in product list page:

log.js:251 [<amp-state> cartList] Failed to parse state. Is it valid JSON? SyntaxError: Unexpected token D in JSON at position 160
    at JSON.parse (<anonymous>)
    at pb (json.js:112)
    at Db (amp-state.js:153)
    at xb.push.f.l.parseAndUpdate (amp-state.js:122)
    at xb.push.f.l.buildCallback (amp-state.js:83)
    at custom-element.js:478
    at new Promise (<anonymous>)
    at HTMLElement.Ii.b.build (custom-element.js:475)
    at hi.f.build (resource.js:336)
    at Nj (resources-impl.js:539)

Error/warning during search AMP
https://gyazo.com/8ca4fa8107e22fb7326533c303ef3c85

log.js:251 [<amp-state> cartList] Failed to parse state. Is it valid JSON? SyntaxError: Unexpected token D in JSON at position 160
    at JSON.parse (<anonymous>)
    at pb (json.js:112)
    at Db (amp-state.js:153)
    at xb.push.f.l.parseAndUpdate (amp-state.js:122)
    at xb.push.f.l.buildCallback (amp-state.js:83)
    at custom-element.js:478
    at new Promise (<anonymous>)
    at HTMLElement.Ii.b.build (custom-element.js:475)
    at hi.f.build (resource.js:336)
    at Nj (resources-impl.js:539)
log.js:251 [amp-list] Missing "binding" attribute. Using binding="refresh" is recommended for performance.

dropdown filters works strange
https://gyazo.com/7552f3c5a3502ca259d88182bb4d2d7a


Missing Data and information in all products detail pages
https://gyazo.com/a294d87bcbb70e25aafed106c8358d1c


AMP - home page validation error:
https://gyazo.com/4cf6e6c9dcd5d1eb926d1597852426c4


https://validator.ampproject.org/#url=https%3A%2F%2Fwww.enotecapirovano.com%2Fit%2Fmobile



PS: 1.7.6.5
PHP: 7.2.19

Fred 11 May 2020, 13:24

Can I update your store https://enotecapirovano.com/ ? as I can see it’s not updated

Marco Montanari 11 May 2020, 15:31

Hi, fred i’ve tried to upgrade the 5.4.1 on my local server and i had tons of problems.
I did a backup now if you want to apply the upgrade, you are more expert then me.


Please add this fix i’ve attached to your theme, because it emprove the datasheet in AMP a lot and i snot available in your 5.5.0 because i released the same day you did 5.5.0.
file must be in templates/mobile/catalog/


Another patch i did is for search button moved in top position in AMP to be clickable.
I attach the file again and must be placed in: alysum\templates\mobile\modules\ps_searchbar


I hope you have more success then me to upgrade because 5.5.0 version espceially the theme editor is completely not working

Attachments:

product.tpl (34 KiB)
ps_searchbar.tpl (3.9 KiB)
Fred 11 May 2020, 17:57

I just updated the theme and see a couple of problems.
We have tested out this update over two weeks, but that’s really hard to catch all possible problems because every customer has his own configuration.
I’ll try to fix current issues as soon as possible

Marco Montanari 11 May 2020, 18:11

well the homepage is completely ruined :(
also the product sliders are completely not working!

well we are in production Fred, when you think you will fix that?

Fred 11 May 2020, 18:20

Hope today

Marco Montanari 11 May 2020, 18:34

problem here are terrible.
https://gyazo.com/13fe3bce6ea2a800d33778e4ccd0c937


if you log and go in this page there are testimonials!
https://www.enotecapirovano.com/it/account https://gyazo.com/93000ed7178b07dbbbf6427be17a18e1 testimonial block is everywhere
https://gyazo.com/b32f63a0a97b2c2f41166a3e550ed732


no more dorpdown on headers icons!
https://gyazo.com/a45fc81322ad7f034d1608a91bf3d5e4


error in revolustion slider
https://gyazo.com/84745b2ba380d70e0ebfccb7afd7f3a6


theme 5.4.1 persist?
https://gyazo.com/344da72bc83f98ba6a703760fd71f4e4


Where AMP is configurable? is missing the AMP menu


Is possible to make all the dropdowns to alligh like thecart dropdown to avoid to exit from the window?
https://gyazo.com/c409c2e1f5bc4c0cd035198df691381a


If we change Brand color on miniature not work because there is a Theme general setting that overwrite it: https://gyazo.com/62e1507c821a051d65af7c231ee4e9f5


AMP - error in search (console)
https://gyazo.com/2f95ed375dae944b0fbeb4ac4ff205b8



we don’t use special mod on you theme why is completely destroied the home page

Please tell me when you can fix all or we need to return to previous situation!

Fred 11 May 2020, 18:55

most of problems solved. Keep woking on the rest

Fred 11 May 2020, 22:34

- all issues has been fixed, please test it out.
- Where AMP is configurable? - go to modules, find AMP, and click configure
- Is possible to make all the dropdowns to alligh like the cart dropdown - you need this option https://take.ms/nUDcI

Marco Montanari 12 May 2020, 03:15

The revolution slider in home page not works due to a js error:
https://gyazo.com/2652c72840819f2f6705d1e531e0f057
Seems the revslider module continue to deactivate itself every time without any reason!


please remove also the console.log(’mouseenter’); ferom alysum.js if is not necessary


Is possible to make all the dropdowns to alligh like the cart dropdown - you need this option https://take.ms/nUDcI
Yes but the problem is i need to keep aligned center the iconswhen size srinks like: https://gyazo.com/0ed3cf9c567f06b33b01a774a0b1baef The solution is to add to every dropdown in header to the div the css:

.pkheaderitems .dd_container {
    right: 0px;
}

Like you did in #desktop_cart


Faceted filters are broken: https://gyazo.com/974e2115be4109ce1644309732ebc064

#search_filters .facet>ul {
    max-height: 300px;
    overflow: auto;
}

the overflow:auto seems it broke the dropdown effect and is a css in the theme so is better you verify the default theme.
In 5.4.1 i’d patched with this code:

.dropdown-menu {
    overflow-y: scroll; 
    max-height:300px;
    overflow: auto
}

and

/* stylize the faceted filter chekbox */
.limitedscroll {
    overflow-y: scroll;
    max-height: 250px;
    overflow-x: hidden;
}

the limitedscroll is added in the tpl facets.tpl @line 69 like:

        <!--/ALYSUM-->
        {if in_array($facet.widgetType, ['radio', 'checkbox'])}
          {block name='facet_item_other'}
            <ul id="facet_{$_expand_id}" class="limitedscroll collapse{if !$_collapse} in{/if}">
              {foreach from=$facet.filters key=filter_key item="filter"}
                {if !$filter.displayed}
                  {continue}
                {/if}

and works.


In Tablet version no qty and purchase button:
https://gyazo.com/666d3c0838b1316b25bedb589c318104


AMP search cerate json errors inside the console
https://gyazo.com/882c0775791794e1e82049658486284c


AMP home page is not validate because alt and title text are not escaped/sanitized as you do in product miniatures in product list
https://validator.ampproject.org/#url=https%3A%2F%2Fwww.enotecapirovano.com%2Fit%2Fmobile


Homepage - TTFB very hight cause probably by the revslider error or by product list carousel sql call?
https://gyazo.com/fee6f64bb1a0eb417dfea7cd580532d9 Other pages are very fast.


Upgrade to 5.5.0 is stuck in 5.4.1
https://gyazo.com/5a559276a102f96719147cda044617e4 There is somethings going wrong.


In favorite dropdown list in header is missing the X icon to remove single favorites.
If for some reason you have eliminated the dropdown tp show the content for me could be also removed.
https://gyazo.com/5a4ef51b8da54b7ce34a4cc962b75b25


Scroll to top icon in wrong place
https://gyazo.com/ac4b8b4fc536ac87b31f3940c4fda670


AMP: apply a filter and try to remove the filter is impossible:
https://gyazo.com/c05ad7d8719e9be482230570665c2e0c there is no option to select in one filter the “No Selection” or have a list of applied filters to delete like on desktop.
Iphone X: https://gyazo.com/e6047471bd44ffd6126e870395195455
Same for Android OS


in Theem Editor > by setting “Product Listing” to list dosen’t work it still use grid as default (cleaned cache and so on nothing change!)



I hope you can fix it, thanks!

Marco Montanari 12 May 2020, 14:32

Viewed products are not on carousel anymore and not styled as SAME CATEGORY block
https://gyazo.com/69c92b7f25a1615fb67e989dcc723de5

Fred 12 May 2020, 22:03

I don’t understand why changes I made in theme files are not applied, maybe you have some additional cache - https://take.ms/BRJ7A

Please try to edit the file yourself

Marco Montanari 12 May 2020, 23:19

i cannot do nothing now the site is in error 500 in debug


https://gyazo.com/9d26130ab7adcb16823edc7f1a506486


i usually have no problem changing files.
Cache was disabled if i remeber right

Fred 12 May 2020, 23:25

I just checked the issue what you reported about debug mode. Now I have disabled it

Marco Montanari 12 May 2020, 23:28

that crash is responsible probably of the revslider crash and deactivations and the ovverride yuo try with ps_viewedproduct.tpl?
How is possible to fix?

Fred 12 May 2020, 23:29

we are trying to figure out how that happens

Marco Montanari 12 May 2020, 23:31

ty Fred!
I hope you will find the problem, i see other customers have the same problem on slider and part of the theme too…

Marco Montanari 13 May 2020, 09:47

Good morning, Any news?

Fred 13 May 2020, 10:54

Not yet, but in progress…

Marco Montanari 13 May 2020, 11:10

any ETA?

thank you

Marco Montanari 13 May 2020, 11:43

I’ve personally check the Alysum theme, to see how fix going on, and i noticed that is not a 5.5.0 version, seems more an hybrid of 5.4.1 with some 5.5.0 parts you manually added:
https://gyazo.com/7b0ec69e5aa24542108ee2420851c96f


i confronted a 5.5.0 full theme with the actual online: https://gyazo.com/54dc82ed7b1834cf293b2fe88728af6e

Sure the update you did was done right?

Fred 13 May 2020, 16:18

Yes, I also noticed something weird with your update.
I can try to upload all files manually to be sure in update

Marco Montanari 13 May 2020, 16:26

well i had no updated to 5.5.0
was 5.4.1 with some fix we did on tickets

Was you in one ticket that offer to update by yourself my installation from 5.4.1 to 5.5.0 :)

Fred 13 May 2020, 16:27

Should I make an update manually?

Marco Montanari 13 May 2020, 16:36

Fred do what you think could fix the problem
I’ve no idea why 5.5.0 is so bad respect 5.4.1 where i’ve no debug errors just some ticket to close

I did on my localhost 5.4.1 to 5.5.0 update and the site was not working as you find out by doing by yourself in enotecapirovano.com

I’ve opened this ticket watching my localhost upgrade, after you did an upgrato to my live server obtaining the same problems.
Do manually whay you think could fix all the problems and crash.

Thanks!

Fred 13 May 2020, 17:24

So I just manually make an update.
- revolution slider seems not disabling now
- Theme Settings front office issues seems fixed now.
- Debug mode issue, I have found out similar issue https://www.prestashop.com/forums/topic/949869-uncaught-exception-unable-to-generate-a-url-for-the-named-route-admin_link_block_list-as-such-route-does-not-exist/ Try the solution from that thread

Marco Montanari 13 May 2020, 20:35

after 5.5.0 “your” update Status


Removing manually the cache seems works for the debug error!


Bug persist: https://gyazo.com/6ac99c1a08599e26b52648cda1299828 I fixed it again but you need to remove from theme.css a bad css as eplained before (theme.css ps_facetedsearch\views\templates\front\catalog\facets.tpl)


AMP crash: https://gyazo.com/15cf77d0f76cd38a7df415359120b60c I fixed by myself installing pk_amp latest version 1.1.2


AMP home page miniatures not pass the validation cause title and alt not sanitized https://validator.ampproject.org/#url=https%3A%2F%2Fwww.enotecapirovano.com%2Fit%2Fmobile

I fixed with the code:

title="{$product.name|htmlspecialchars}

AMP search fire script errors in console: https://gyazo.com/d594f713a172e5caeaa283a3bc5423b0


In Tablet version no qty and purchase button:
https://gyazo.com/666d3c0838b1316b25bedb589c318104 [FIXED]


AMP: apply a filter and try to remove the filter is impossible from dropdown:
https://gyazo.com/c05ad7d8719e9be482230570665c2e0c there is no option to select in one filter the “No Selection” or have a list of applied filters to delete like on desktop.
Iphone X: https://gyazo.com/e6047471bd44ffd6126e870395195455 Same for Android OS


Revslider deactivating by itself again randomly as son ass in backoffice someone saves a product or something.
https://gyazo.com/f84c53f8dce101fa6339da8f46c59d5d [FIXED] pk_themesettings was leaved in modules and create problems with the NEW pkthemesetting


Product title multiline not work: https://gyazo.com/46a5700f56f74a0a5f8d5c5e09eeb068 On screen you see is cutted: https://gyazo.com/f3f1f5bc9e30f85f5fe8eea2ed94749c

<h3 class="product-title text-left{if $pkconf.pm_title_multiline} ellipsis{/if}" itemprop="name">

is wrong! must be

<h3 class="product-title text-left{if $pkconf.pm_title_multiline == false} ellipsis{/if}" itemprop="name">

CATEGORY PRODUCT ORDER LIST: Watching product list there is no short from new to old and viceversa is possible to add like in 1.6 version default theme?


what is the folder 5.5.0 in site root??


AMP - add Discount Countdown features like in desktop?


AMP - Missing a parameter from Product List Type like on desktop version of Product Lsit: https://gyazo.com/c310e8d428fe54241488572be1e728ab


OpenGraph error
https://www.enotecapirovano.com/it/champagne/3081-champagne-brut-belle-epoque-2011-15-lt-perrier-jouet.html

  <!-- Open Graph / Facebook -->
  <meta property="og:type" content="website">
  <meta property="og:site_name" content="Pirovano Flavio &amp; C s.n.c.">
  <meta property="og:url" content="https://www.enotecapirovano.com/">
  <meta property="og:locale" content="it-IT">
  <meta property="og:title" content="Champagne Brut Belle Epoque 2011 Perrier – Jouet - EnotecaPirovano">
  <meta property="og:description" content="Champagne francese Perrier Jouet Belle epoque magnum 2011, annata fresca, vivace e dai profumi agrumati, vino per feste speciali che non delude mai">
  <meta property="og:locale:alternate" content="en" />
  <meta property="og:locale:alternate" content="it-it" />

The og:url is wrong must be the same of the canonical:

<link rel="canonical" href="https://www.enotecapirovano.com/it/champagne/3081-champagne-brut-belle-epoque-2011-15-lt-perrier-jouet.html">

You can test any product page with the Facebook debugger: https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fwww.enotecapirovano.com%2Fit%2Fchampagne%2F3081-champagne-brut-belle-epoque-2011-15-lt-perrier-jouet.html

Using the test you will see that are missing other og parameters but lookign at the end of <head> there is another part of operngraph code that is right.

  <meta property="og:type" content="product">
  <meta property="og:url" content="https://www.enotecapirovano.com/it/champagne/3081-champagne-brut-belle-epoque-2011-15-lt-perrier-jouet.html">
  <meta property="og:title" content="Champagne Brut Belle Epoque 2011 Perrier – Jouet - EnotecaPirovano">
  <meta property="og:site_name" content="Pirovano Flavio &amp; C s.n.c.">
  <meta property="og:description" content="Champagne francese Perrier Jouet Belle epoque magnum 2011, annata fresca, vivace e dai profumi agrumati, vino per feste speciali che non delude mai">
  <meta property="og:image" content="https://www.enotecapirovano.com/5054-large_default/champagne-brut-belle-epoque-2011-15-lt-perrier-jouet.jpg">
      <meta property="product:pretax_price:amount" content="294.262295">
    <meta property="product:pretax_price:currency" content="EUR">
    <meta property="product:price:amount" content="359">
    <meta property="product:price:currency" content="EUR">
      <meta property="product:weight:value" content="4.500000">
  <meta property="product:weight:units" content="kg">
  

in head.tpl the opengraph block must be more smart like:

{if $page.page_name !== "product"}
  {block name='opengraph_tags'}
  <!-- Open Graph / Facebook -->
  <meta property="og:type" content="website">
  <meta property="og:site_name" content="{Configuration::get('PS_SHOP_NAME')}">
  <meta property="og:url" content="{$urls.current_url}">
  <meta property="og:locale" content="{$language.locale}">
  <meta property="og:title" content="{$page.meta.title}">
  <meta property="og:description" content="{$page.meta.description}">
{foreach from=$urls.alternative_langs item=pageUrl key=code}
  <meta property="og:locale:alternate" content="{$code}" />
{/foreach}
  {/block}
{/if}

How to remove this part of discount in the product miniature?
https://gyazo.com/b0d1e3704dbf8b8aa9cef3df0d4ff7e6


Impossible in theme editor to use a product page made with the builder https://gyazo.com/88067ee2586f293f17e202963046ea10



thanks for now

Attachments:

facets.tpl (9.3 KiB)
theme.css (206.6 KiB)
Fred 20 May 2020, 17:19

- facet dropdown: I added spacial class

.facet-dropdown .dropdown-menu {...

- AMP crash: Fixed
- AMP home page miniatures not pass the validation - added

<amp-img src="{$product.cover.medium.url}" ... 
{if !empty($product.cover.legend)} alt="{$product.cover.legend|escape:'htmlall'}" title="{$product.cover.legend|escape:'htmlall'}"{else} alt="{$product.name|escape:'htmlall'}"{/if}></amp-img>

- AMP search fire script errors - In progress… - In Tablet version no qty and purchase button: - https://take.ms/gcTdf

- We are going to add “Reset Filter” button
- Revslider deactivating by itself - still in progress
- Product title multiline not work - fixed in the next update

Fred 21 May 2020, 17:30

I just changed

alt="{$product.cover.legend|escape:'htmlall'}"

to

alt="{$product.cover.legend|htmlspecialchars}"