- Priority: 0
- Status: Closed
- Theme: Venedor
-
Assigned To:
Fred
- Private: No
- Open Date: 01.09.20, 21:28
- Opened by: Ionut Iordache
- Closed by: Anonymous Submitter
- Closed on:
- Reason: Not a bug
Ticket #18993 - Amp Venedor cart Bugs
Hi there,
I have tested AMP theme for mobile.
I have descovered some bugs regarding basket.
I have followed few steps that I suggest you to follow to:
problem 1
1. Added 4 products in the basket.
2. Press on the round black circle from the bottom where is shown the number of the products in the basket.
3. We go to checkout, now I click on the header cart to check if my products are ok. (Picture 1.jpg)
4. Once there I want to add more products, and I click basket to add more products
5. Now I am in the basket, but instead to see my products, I see a ghosting product I didn’t put in my basket and only this one is visible, the rest of products no. (this product shouldn’t be there, Pictures 2.jpg, 3.jpg)
6. If I click X button from top right, the product goes away and the real product appears correctly (Picture 4.jpg )
In case of more line products in the basket, they are nor visible until you delete the phantom product besides the fact there is an empty space under the phantom product which say there is more there. (Picture 3.jpg)
problem 2
When click on the header basket and want to delete some products, sometimes doesn’t work.
I don’t know the reason and the situation is not present all the time, just sometimes. Maybe is related with the phantom product.
problem 3
In the customer area I have some accordion elements I don’t need, currency and language.
My store is for my country only, and I don’t need these elements.
I don’t know how to disable these elements.
On your demo site there are some nice animations for the login area, cart area when delete all the products. In the version theme I have downloaded those animations are not present
I look forward for an answer how to fix these problems.
Thanks.
Comments
Hi, Ionut.
We currently working on a new AMP module version. hope to finish it within a week. Then I can make an update for you. Hope that’s not critical and you can wait a bit
Hi there.
No rush, I’ve done some research and I’ve noticed only some browsers have this problem.
The main browser in Android 10 is one affected. Now I see Chrome having problems but with phantom product at the end of the list.
I think it’s about cache or something.
Thanks.
ok
Hi there,
Any good news?
Sorry for the delay.
Yes, the new version was released recently. I can install it for you.
but I need access to your server through FTP and back office
Right now I’m not able to connect
Hi there.
If I download the theme again, is in the package or should I download the module separate?
Besides of that I’ve done some modifications and I would like to preserve.
Thanks.
we didn’t release the module in for the theme yet. I can install it separately
If you give me the module I will install it.
Thanks.
1. unzip, upload to your prestashop and install the module https://www.dropbox.com/s/uip0t2u5ait3j12/pkamp.zip?dl=0
2. unzip and upload templates to the folder /themes/alysum/templates/mobile/ - https://www.dropbox.com/s/lg2mw5xcxe0efsa/mobile.zip?dl=0
Hi there.
I have installed the modules and definitely it is an improvement.
But still there are some little things to do.
1. Despite the Show Quick Checkout is active, it is not displayed on pages, except the checkout page (pic 1.jpg).
2. Customer account section. Where a table fields appears, there are no placeholders or labels for fields. There is no way to figure out what should be in that field (pic 2.jpg). Available when a new address is added or modified the old one, or personal info.
3. Some modules on first page do not recognize the picture path if is installed in a subdomain. For example images gallery module.
4. In the admin left menu Venedor Settings/AMP tab, the AMP configuration redirects to the old version that have a different name than the one provided above. Last item in the menu is the real connection to the good one.
5. Two of the sections in the customer area (My Favorite Products and My Wishlists) redirects to a different pages than AMP and obviously it is a strange transition between two types of layouts.
That’s it for now, I will come back for more if I discover something else.
Thanks.
Attachments:
1.jpg(288.4 KiB)2.jpg(111 KiB)Hi, Ionut.
I’m not able to login to your back office
Hi there.
The site is running as a subdomain on a different server.
Sorry.
but how I can access to files?
Hi there,
I’ll try to create new credentials to have access.
Thanks.
Hi there,
Or you can give the files or you guide me to fix things.
I can do it.
Thanks.
Hi there,
The info for FTP and admin are changed,
The site link I couldn’t change, but you figure out.
Thanks.
1. Quick Checkout is fixed
Other in progress…
1. How to access to files of the store https://www.joacadeweekend.ro/dev-bikenature/
2. Please add a license for that store and fill out access details
Hi there,
You have the credentials for FTP already.
The site is hosted as subdomain on the domain joacadeweekend.ro, because the server resources of bikenature.ro are not enough. If I upgrade now the apache and php, the site will crash.
When the bugs will be fixed we migrate to the bikenature.ro domain.
Thanks.
Hi there,
Another problems I have found is the product page (amp page) when a product has combinations.
1. When I change the variant of the product, the reference number doesn’t change, not even in product details. I would like to have this product code changed, when a variant product is changed like in the regular mobile version.
2. When a product has combinations, and one of the combinations is out of stock and is default combination, the product page displays out of stock, first time when the product page is accessed.
When change to another variant with stock, out of stock message goes away but the ‘add to cart’ button doesn’t appear any more.
When I try to move back to the ‘out of stock’ variant (in this case white variant) the message ‘out of stock’ doesn’t appear, again.
For this scenario you can choose product 9.
That’s it for now.
Thanks.
1. Fixed
2. Please give me a link where I could see that
Hi there,
The public link for the theme is:
https://www.joacadeweekend.ro/dev-bikenature For the moment only the mobile theme I’ve been tested.
Thanks.
but what product I need check to see the issue? Please give me a link to a product
Hi there,
here is the product.
https://joacadeweekend.ro/dev-bikenature/mobile/product/9-mug-the-best-is-yet-to-come
Thanks.
please test it out now
Hi there,
Some of them are fixed, but others not.
Besides of that we have new issues, like:
1. Product with variants, when select other variant than default and is available in stock, the price is displayed with discount, but obvious the is no discount there, is the same price.
2. When discount appears, at the bottom quick checkout appears too, having 1 product in shopping cart, if is clicked, arrive in the shopping cart but is empty, obvious.
For test:
https://joacadeweekend.ro/dev-bikenature/mobile/product/16-mug-the-best-is-yet-to-come
Thanks.
both issues are fixed https://take.ms/D9LdP
Hi there,
The problems are fixed.
Now I need to display the product reference when a variant product is changed.
In the regular theme I do it with a jQuery code, but in amp files I think is not allowed.
If you have a solution I’m ready to listen.
Thanks.
but reference is changed in AMP as well https://take.ms/P8fLB
Hi there,
Yes you’re right but only when I flushed all the info stored by the browser, shift+refresh it is not enough. When you do a change it is very difficult to see that change is working.
When a product with variants is called, the informations of the default variant are loaded and displayed on the product page.
But the reference of the variant displayed when you access the product page first time, is not the one linked with the variant. For example product 16, it is available for all the products with variants:
https://joacadeweekend.ro/dev-bikenature/mobile/product/16-mountain-fox-cushion When you get on the page, the reference should be, ‘demo_8_ruled’ not ‘demo_8’. The behaviour is to read the master reference instead of the variant reference ‘{$product.reference_to_display}’. When you start to change the variants then it is ok the variants are associated with the real variant reference.
For the products without variants, the reference is displayed correctly.
Thanks.
Another bug I found is regarding the message displayed in various scenarious.
Product number 9 for example:
Link: https://joacadeweekend.ro/dev-bikenature/mobile/product/9-mountain-fox-cushion
Scenario 1:
The product has 2 variants, Alb(White), Negru(Black), the white variant is default and has no stock.
When enter the product page the message is red “Not Available”, you can’t order.
if the variant is changed to black, add to cart button appears and beneath the message " X Produs disponibil cu alte optiuni” (Available with other options). This message should appear when a variant is not available not when has stock.
Scenario 2:
The product has 2 variants, Alb(White), Negru(Black), the black variant is default and has stock.
When enter the product page the message is green “Disponibil” (Available), and you can order.
If change to white, red message again you can’t order. Switch to black, again, message is correct (Available).
This is the right way of displaying but the default variant should have stock.
For scenario 1 and 2 order was not permitted for out of stock variants.
Scenario 3:
The product has 2 variants, Alb(White), Negru(Black), the white variant is default and has no stock.
The order of out of stock is permitted.
When enter the product page the message is green “X Produs disponibil cu alte optiuni” (Available with other options), and you can order.
If change to black, everything is ok but the message where should be “Disponibil” (Available).
Now if you change back to white, message remains, but the button add to cart despite the order is permitted, is not available.
I have tested with 2 browsers, Chrome and Firefox. On Firefox button ‘add to cart’ greys out, on Chrome is the red button.
I’ve tried to clear cache to erase browsers cache, still getting different results.
Thanks.
please try now, it should be correct
Hi there,
I have raised lots of problems.
What has been changed?
Thanks.
The issue with variation and messages should be fixed
Hi there,
This is the only thing I’ve noticed.
Thanks.
What thing?
Hi there,
Seems there is a lot work to do, to match regular version of the theme.
Already 1 month has gone and the is no much improvements.
Probably will not use this theme version till all the problems I’ve raised above are done.
By the way, the reference is not changing any more when a variant is changed.
It worked 2-3 days ago.
Thanks.
Strange, I’l check out what’s happened
fixed https://take.ms/585Se
Hi there,
Still problem with the product nr. 16: https://joacadeweekend.ro/dev-bikenature/mobile/product/16-hummingbird-printed-t-shirt
When the orders are not allowed: First option ‘Ruled’ when selected it displays reference ‘null’ despite the fact has a reference. Only if is not selected as default option. The variant with no stock available is not red any more, the button is grey out.
When orders are allowed: The variant with no stock available still grey out, no button available for order. The rest of the simptoms still present.
Thanks.
currently I don’t see any issue despite the color of the message is grey but not red.
Reference is changes and Add to cart button state as well
Hi there,
Yes indeed, but that grey button should be active, because the the ‘order out of stock’ is permitted.
So button should be active not inactive.
Thanks.
please try now https://take.ms/A2Ljn
Hi there.
Well, now I’ve switched to ‘order not permitted’ for ‘out of stock products and surprise, no variant is allowed to order.
It is strange.
I have compared AMP and desktop product pages and now they works the same, please check it out
Sorry I have to say, don’t work the same.
Switch between themes at the product 16. https://joacadeweekend.ro/dev-bikenature/mobile/product/16-brown-bear-printed-sweater Focus on the ‘Squarred’ combination.
At the desktop version is out of stock all the times no matter what you choose and come back to it.
At AMP version it’s out of stock only if is default combination when page loads the product. If change between combinations and come back to it, the button add to cart is active despite the message says something else.
Thanks.
Sorry for the delay, we keep working on that
Hi there,
I have encounter an error when I had to save settings in ‘Theme Settings’ module.
You can’t save anything in this module. Returns 500 error.
I have attached the error.
Thanks.
Attachments:
capture1.JPG(22.1 KiB)One more thing, I have to add a captcha code to the newsletter module.
What page did you use because I’ve tried to modify 3 of them with no success.
And one more thing, the GDPR consent box, should inactivate the button subscribe until is ticked. I didn’t see this kind of functionality here on your template.
Thanks.
In the page builder I would like to add some modules like ps_specials or ps_newproducts, but are not there like in previous version of the theme.
Thanks.
1. Theme Settings is fixed
2. If you mean this module https://take.ms/O3Qw9 you have to edit this file /modules/pspagebuilder/views/templates/front/widgets/widget_newsletter.tpl
3. summit button state is fixed
4. please make sure you have those modules installed
Hi there,
Thanks for fix, I think the widget ‘contact form’ from footer should be fixed for gdpr submit button functionality as well.
Thanks.
The footer ‘contact form’ and main page ‘newsletter form’ are processed via javascript in ‘/modules/pspagebuilder/views/js\pagebuilder.js’?
Or is just the message you show?
Thanks.
It is correct, the right column now is narrower than the last version of the theme?
I have added captcha functionality for both widgets (newsletter form, footer contact form) and JavaScript checks properly the conditions.
I have 2 questions.
1. Where I can find error phrases for JavaScript errors?
2. I want to add second step, php check the conditions, in case of a bot is trying bypass the JavaScript check. I want to confirm what pages and functions process this check.
Thanks.
1. check out this file /modules/pspagebuilder/pspagebuilder.php
2. I’m not sure I can help you with such customization
Hi there,
I have done php check for newsletter widget in ‘/modules/pspagebuilder/classes/widget/newsletter.php’ For widget ‘contact_form’ ajax send to ‘/module/pspagebuilder/contactform_ajax’. Is this correct? Where should I get this?
I need to you to tell me where do you process Post variables from this widget.
Thanks.
which widget? please take a screenshot of that widget
Hi there
I talk about footer contacform.
I need the php file which process the variables from the widget.
Is this the one?
/modules/pspagebuilder/controllers/front/contactform_ajax.php
Thanks.
Attachments:
footer_form.JPG(15.4 KiB)yes, the file is /modules/pspagebuilder/controllers/front/contactform_ajax.php
Hi there,
Thanks for the tips. Problem solved.
How is the progress for amp theme, I mean the fixes regarding the product page and the behaviour of the ‘add to cart’ button in various situations.
Thanks.
I have enabled Debug mode to see error messages and found out you are using php v.7.3. PrestaShop currently doesn’t support it, Please downgrade php to 7.2
Hi there,
I have downgraded the php to 7.2 and there is no difference.
The button has the same behaviour. I think it’s a display css problem.
Thanks.
There is an error on this page.
After a while is asking to submit again the form, basically send the same answer twice if I press yes.
1. what product I can test out? we spent last month on this issue and I suppose it’s finally fixed now. I have tested out this product and all seems works correctly https://joacadeweekend.ro/dev-bikenature/mobile/product/16-mountain-fox-notebook
2. After a while is asking to submit again the form, basically send the same answer twice if I press yes. - yes, that is a default browser’s behaviour. You just have select “no”
Hi there,
I don’t want bother you but my test shows if far away to be done, but I’ve decided to leave it for now.
I’m not sure if we going to use this amp theme, is not mature yet.
Now I want to step forward to the desktop theme and to fix or bring improvements to this theme even on mobile version.
Thanks.
Sad, but ok, I understand. In any case we are working on AMP improvenment all the time, hope it will fit your needs in future
Hi there,
Let’s talk about the desktop theme.
I have a test products nr. 16 and nr 17. As usual.
https://joacadeweekend.ro/dev-bikenature/energizare/16-28-mountain-fox-notebook.html#/22-paper_type-ruled https://joacadeweekend.ro/dev-bikenature/cross-country/17-35-brown-bear-notebook.html#/25-paper_type-doted In this moment the products have 4 combinations 2 with stock 2 with stock 0.
The order type is set to allow product order if is not in stock. (squared and ruled are 0) I have changed the messages to see the difference between options.
Now is the default theme selected, when you test the behaviour on the original theme when select between combinations, switch on your theme and do the same thing and tell me what you see. Please check both situations when orders allowed and not allowed for the out of stock products, check what button does when in both situations (sometimes refreshes a bit slower). Especially when the order is allowed and the default combination is out of stock.
Thanks.
I see the message is changing to “Stock 0 check with the supplier” Then I switch your store to Venedor theme and see there the same, see my video https://mega.nz/file/dQ430YyK#vpPNgd8mirDnYemfPXpKfmBaxaErUuLnNiZsjBj4tHE
Hi there,
Let’s go with some bugs in the desktop theme.
1. Mobile version of the desktop theme should work with the hamburger menu. Test, it is not functional, the menu is not expanding.
2. Footer, mobile version, contact us field is hidden, despite the widget title is shown
3. Product labels have some display bugs. Product https://joacadeweekend.ro/dev-bikenature/cross-country/17-35-brown-bear-notebook.html. Try to change between product options to understand what is going on.
4. The desktop theme on the desktop version, when you are logged, the top menu where customer can log in, the icon transforms into a word where it says ‘log out’. In the old version of the theme icon was staying there, and a menu expand when you hover with the mouse over. Give a try on the https://www.bikenature.ro, create an account. I would like to preserve the old style.
Ok now I’m ready to deploy the new server, and this time I need you to tell me where do you do modifications because I need to migrate the code from here to the new location.
Thanks.
1&2&3. Try following fix:
4. Fixed
Hi there,
Problems solved still more to go.
1. The search ajax field doesn’t work and it’s useless in this form. The theme we have now in public is much cleaner and the field works as intended. If is not changed the code, I could migrate the old header to the this version, I need assistance.
2. Product page, product no. 17, https://joacadeweekend.ro/dev-bikenature/cross-country/17-32-brown-bear-notebook.html#/22-paper_type-ruled, when click on the product picture, a large picture pops up and the rest of the thumbnails in the right hand side. As you can see when multiple pictures are available, the arrows up and down should appear, and we don’t have any errors. besides of that the thumbnails are not aligned in container, are shifted to the right.
3. For the point 4 above, where I did you changed the code?
Thanks.
1. The search works fine for me https://take.ms/HlZRy
2. Try following CSS code to get it fixed https://take.ms/2VFwi
3. Updated file is /modules/pk_customlinks/pk_customlinks.tpl
Hi there,
1. The capture is from the live site. There is ok. My bad I didn’t specify where the problem is. Mobile version of Venedor theme.
https://joacadeweekend.ro/dev-bikenature/. On the mobile device the touch of the search square doesn’t do anything like ajax search.
The mobile version of venedor that we have now on the live, has a different approach on mobile, maybe we can use that if the code didn’t suffered much of a change.
2. I didn’t see any CSS fix in the link you send me, only a picture. By the way I’ve noticed this problem long time ago, it is present on the live site, even now.
Thanks.
1. fixed. Updated file is /themes/venedor/assets/css/custom.css
2. I just fixed arrows for you https://monosnap.com/direct/iYXMblqD4hnDgqWiul6G8S0ZDSE9Ap
Hi there,
1. Yes, the fix works only if you navigate in browser with the mobile version and use the mouse hover. If you activate the touch, you not going to have the same behaviour. Try on mobile to see if you can expand that field with the finger. I would like more the solution I have now. I have attached the pic (screenshot). Is more clear and works in any circumstances. What template and css I have to transfer to make it like this?
2. The arrows are not centered and the product thumbnails are shifted, not centered. My pictures are squared and a part of thumbnail is hidden. pic2.jpg
Attachments:
Screenshot_20201203-011735_Ch...(824.2 KiB)pic2.jpg(148.9 KiB)1. Fixed and works correctly on all devices
2. try following CSS fix
Hi there,
I have fixed point number 2 in a different manner.
Point number 1 still a problem. On mobile phone or tablet doesn’t work.
Thanks.
Try following CSS to get this view https://take.ms/GMoo7
Hi there,
Cool big step forward. Now I need to put back the icons instead of words in top header navigation (my account, login, etc)
And the basket is gone.
Maybe the same solution as the one in live server will do.
Thanks.
Hi there,
Problem solved in a way.
Now I have no access to the shopping cart in the header.
Thanks.
I can offer you the following solution https://take.ms/7wHve
Hi there,
The solution works.
Now we have to center the watch list on mobile.
Thanks.
Hi there,
works partial.
The basket now is off, to the left, and the level 3 menu is the same off to the left.
Thanks.
Hi there,
it works well.
1. For I don’t know what reason, I have red borders on input type email in footer contact widget and contact page. I think it is a JavaScript issue or something.
2 The module pk_wishlist. When share the link of the list, when accessed, on desktop resolution, the products are displayed on a long vertical list instead of grid.
3. The module pk_favorites has a bug as well. The products saved are displayed as large as the page dimensions are, desktop version, the same in a vertical list instead of a grid.
Thanks.
1. I don’t see red borders there https://take.ms/3ISCr
2. We are going to remove outdated wishlist module and replace it with new official version https://github.com/PrestaShop/blockwishlist/tree/new-module
3. Fixed
Hi there.
1. It was only on firefox :invalid displays red borders.
2. Do I have any chance to get the new wishlist module version?
Thanks.
Is there any chance to make it compatible with the version 1.7.7.1.
I’ve noticed that product comments is not loading on the product page. I’ve done a separate test on this version.
In the meantime I’ve created a new server where I will deploy the new site. (https://new.bikenature.ro/energizare/20-mountain-fox-notebook.html). Check the product comments module, the rest it’s fine, seems so.
Thanks.
We currently working on update. Hope to release it within a couple of weeks